Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in unix id-lookups#57

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-exec-injection-unix-lookups-11013052689945252727
Open

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in unix id-lookups#57
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
sentinel-fix-exec-injection-unix-lookups-11013052689945252727

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented May 24, 2026

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Unsanitized parameters (username and groupName) were passed to execSync inside interpolated strings, allowing malicious inputs to execute arbitrary shell commands.
🎯 Impact: Potential RCE (Remote Code Execution) or unauthorized access if a crafted username/group name is passed to getUidFromUsername, getGidFromGroupName, or getHomedirFromUsername.
πŸ”§ Fix: Replaced execSync with execFileSync and split arguments into an array, bypassing the shell evaluator completely. Added -- prefix before dynamic inputs to additionally prevent argument injection.
βœ… Verification: Ran workspace tests in packages/core ensuring no regressions.

Note: Addressed in packages/core/src/unix/id-lookups.ts


PR created automatically by Jules for task 11013052689945252727 started by @Donach

Migrate string-interpolated `execSync` calls to array-based `execFileSync`
with `--` argument isolation to prevent command/argument injection
during unix user and group lookups.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant