π‘οΈ Sentinel: [CRITICAL] Fix command injection in unix id-lookups#57
Conversation
Migrate string-interpolated `execSync` calls to array-based `execFileSync` with `--` argument isolation to prevent command/argument injection during unix user and group lookups. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Unsanitized parameters (
usernameandgroupName) were passed toexecSyncinside interpolated strings, allowing malicious inputs to execute arbitrary shell commands.π― Impact: Potential RCE (Remote Code Execution) or unauthorized access if a crafted username/group name is passed to
getUidFromUsername,getGidFromGroupName, orgetHomedirFromUsername.π§ Fix: Replaced
execSyncwithexecFileSyncand split arguments into an array, bypassing the shell evaluator completely. Added--prefix before dynamic inputs to additionally prevent argument injection.β Verification: Ran workspace tests in
packages/coreensuring no regressions.Note: Addressed in packages/core/src/unix/id-lookups.ts
PR created automatically by Jules for task 11013052689945252727 started by @Donach