Skip to content

⚡ Bolt: [performance improvement] Batch loadConfig in worktree creation#55

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt/batch-load-config-worktrees-12585339605634931599
Open

⚡ Bolt: [performance improvement] Batch loadConfig in worktree creation#55
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
bolt/batch-load-config-worktrees-12585339605634931599

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented May 22, 2026

💡 What

Modified applyWorktreeCreateDefaults inside apps/agor-daemon/src/services/worktrees.ts to accept the pre-loaded configuration instead of invoking loadConfig() on each call. Moved the configuration load to the start of the create() method.

🎯 Why

During bulk worktree creation (when data is an array), the original implementation invoked loadConfig() sequentially for every element. loadConfig() performs synchronous or asynchronous file reading and YAML parsing. Looping over it causes an O(N) configuration read and parse latency which severely harms performance.

📊 Impact

Reduces disk I/O and parsing overhead from O(N) to O(1) for bulk inserts, significantly accelerating bulk worktree provisioning operations. Also eliminates the need to await Promise.all locally, making the mapping fully synchronous and memory efficient.

🔬 Measurement

Run pnpm --filter @agor/daemon test -- src/services/worktrees.test.ts to verify the creation logic remains intact, while evaluating trace logs of loadConfig invocations during bulk inserts.


PR created automatically by Jules for task 12585339605634931599 started by @Donach

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

👋 Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant