π‘οΈ Sentinel: [CRITICAL] Fix command injection in Unix utilities#54
Conversation
Replaced uses of `execSync` with `execFileSync` across Unix utilities (`id-lookups.ts` and `user-manager.ts`) to eliminate command injection vulnerabilities. Argument parsing was updated to pass arrays, using `--` to prevent argument injection, and output discarding was handled securely without shell redirects. Test mocks were also updated to support the new child process methods. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Command injection via shell execution.
execSyncwas being used with string interpolation for dynamic variables likeusernameandgroupNameinid-lookups.tsanduser-manager.ts.π― Impact: If an attacker could control the username or group name input, they could inject shell metacharacters and execute arbitrary system commands as the daemon process.
π§ Fix: Replaced
execSyncwithexecFileSyncto bypass shell execution completely. Arguments are now passed securely as an array, explicitly cast to strings, and prefixed with--to prevent argument injection. Shell redirection (> /dev/null) was replaced with{ stdio: 'ignore' }. Updated corresponding test mocks.β Verification: Ran
pnpm build,pnpm lint:fix, andpnpm testfor the@agor/core/unixpackage to ensure full test suite passes.PR created automatically by Jules for task 14995128911294700721 started by @Donach