Skip to content

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection risk in unix id-lookups#53

Open
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
jules-14796835733922872536-4b4ca92f
Open

πŸ›‘οΈ Sentinel: [HIGH] Fix command injection risk in unix id-lookups#53
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
jules-14796835733922872536-4b4ca92f

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented May 21, 2026

🚨 Severity: HIGH
πŸ’‘ Vulnerability: The id-lookups.ts functions (getGidFromGroupName, getUidFromUsername, getHomedirFromUsername) previously used execSync with string interpolation. This means variables were evaluated in a shell, allowing possible command injection via shell metacharacters.
🎯 Impact: A maliciously crafted username or groupname could be exploited to run arbitrary commands in the daemon context, leading to remote code execution.
πŸ”§ Fix: Replaced execSync with execFileSync. Passed the dynamic variables strictly as arguments via an array and enforced the -- separator to prevent argument injection if an input starts with -.
βœ… Verification: Ran pnpm lint and pnpm test successfully. Confirmed execFileSync implementation is intact and robust.


PR created automatically by Jules for task 14796835733922872536 started by @Donach

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant