🛡️ Sentinel: [CRITICAL] Fix command injection#52
Conversation
🚨 Severity: CRITICAL
💡 Vulnerability: `execSync` was used with string interpolation for dynamic inputs like usernames and group names (e.g., `execSync(\`id -u "${username}"\`)`), allowing arbitrary shell execution if the inputs contained shell metacharacters.
🎯 Impact: An attacker who can control a username or group name input could execute arbitrary code on the host machine.
🔧 Fix: Replaced `execSync` with `execFileSync` to bypass shell execution entirely. Passed dynamic inputs via an argument array with `--` prefixed to prevent argument injection vulnerabilities. Also updated `packages/core/src/db/repositories/sessions.test.ts` and `tasks.test.ts` to use relative path imports rather than the package alias to fix failing tests.
✅ Verification: Ran `pnpm lint` and `pnpm test` successfully. Verified the fix locally via unit tests mocking the exact `execFileSync` behavior.
Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability:
execSyncwas used with string interpolation for dynamic inputs like usernames and group names (e.g.,execSync(\id -u "${username}"`)), allowing arbitrary shell execution if the inputs contained shell metacharacters. 🎯 Impact: An attacker who can control a username or group name input could execute arbitrary code on the host machine. 🔧 Fix: ReplacedexecSyncwithexecFileSyncto bypass shell execution entirely. Passed dynamic inputs via an argument array with--prefixed to prevent argument injection vulnerabilities. Also updatedpackages/core/src/db/repositories/sessions.test.tsandtasks.test.tsto use relative path imports rather than the package alias to fix failing tests. ✅ Verification: Ranpnpm lintandpnpm testsuccessfully. Verified the fix locally via unit tests mocking the exactexecFileSync` behavior.PR created automatically by Jules for task 12112524005261769055 started by @Donach