🛡️ Sentinel: [CRITICAL] Fix command injection in id-lookups#50
Conversation
Migrated `execSync` to `execFileSync` in `packages/core/src/unix/id-lookups.ts` to prevent command injection vulnerabilities from unvalidated username and groupName inputs. Includes explicit string casting and `--` argument injection protection. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
1 participant
🚨 Severity: CRITICAL
💡 Vulnerability: Command Injection. Unvalidated user input was interpolated directly into shell strings executed via
execSync. A malicious user could provide a username or group name containing shell metacharacters to execute arbitrary commands.🎯 Impact: Remote Code Execution (RCE) via shell injection.
🔧 Fix: Replaced
execSyncwithexecFileSyncto bypass shell evaluation and pass inputs directly to the binary. AddedString()casts to preventTypeErrors and used--to prevent argument injection vulnerabilities.✅ Verification: Run
pnpm lint,pnpm build, andpnpm --filter @agor/core test -- src/unix/.PR created automatically by Jules for task 16440073352854733618 started by @Donach