π‘οΈ Sentinel: [CRITICAL] Fix command injection in Unix utilities#33
Conversation
Replaces vulnerable `execSync` calls with `execFileSync` in `packages/core/src/unix/id-lookups.ts` and `apps/agor-cli/src/commands/admin/sync-unix.ts` to prevent command injection from user-controlled inputs. Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
|
π Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a π emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
π¨ Severity: CRITICAL
π‘ Vulnerability: Unsanitized user inputs (
username,groupName,sudoUser) were concatenated into shell strings viaexecSync(), leaving the system highly vulnerable to command injection.π― Impact: An attacker could craft a malicious username or group name containing shell metacharacters (e.g.,
; rm -rf /) that would be executed with the privileges of the Node.js application (often root when running daemon sync operations).π§ Fix: Migrated all
execSyncusages handling dynamic input toexecFileSync, passing user input directly via an argument array to completely bypass the shell's command interpolation, nullifying the command injection vector.β Verification: Verified by ensuring the code passes
pnpm lintandpnpm test. The CI workflow should succeed cleanly.PR created automatically by Jules for task 1592603489307158644 started by @Donach