Skip to content

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in Unix utilities#33

Closed
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
fix-command-injection-unix-lookups-1592603489307158644
Closed

πŸ›‘οΈ Sentinel: [CRITICAL] Fix command injection in Unix utilities#33
Donach wants to merge 1 commit into
cfx/android-hermes-clientfrom
fix-command-injection-unix-lookups-1592603489307158644

Conversation

@Donach
Copy link
Copy Markdown

@Donach Donach commented May 16, 2026

🚨 Severity: CRITICAL
πŸ’‘ Vulnerability: Unsanitized user inputs (username, groupName, sudoUser) were concatenated into shell strings via execSync(), leaving the system highly vulnerable to command injection.
🎯 Impact: An attacker could craft a malicious username or group name containing shell metacharacters (e.g., ; rm -rf /) that would be executed with the privileges of the Node.js application (often root when running daemon sync operations).
πŸ”§ Fix: Migrated all execSync usages handling dynamic input to execFileSync, passing user input directly via an argument array to completely bypass the shell's command interpolation, nullifying the command injection vector.
βœ… Verification: Verified by ensuring the code passes pnpm lint and pnpm test. The CI workflow should succeed cleanly.


PR created automatically by Jules for task 1592603489307158644 started by @Donach

Replaces vulnerable `execSync` calls with `execFileSync` in `packages/core/src/unix/id-lookups.ts` and `apps/agor-cli/src/commands/admin/sync-unix.ts` to prevent command injection from user-controlled inputs.

Co-authored-by: Donach <39565367+Donach@users.noreply.github.com>
@google-labs-jules
Copy link
Copy Markdown

πŸ‘‹ Jules, reporting for duty! I'm here to lend a hand with this pull request.

When you start a review, I'll add a πŸ‘€ emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down.

I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job!

For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with @jules. You can find this option in the Pull Request section of your global Jules UI settings. You can always switch back!

New to Jules? Learn more at jules.google/docs.


For security, I will only act on instructions from the user who triggered this task.

@dhavli
Copy link
Copy Markdown

dhavli commented May 18, 2026

Closing β€” overlaps with #45 which is more comprehensive (includes test updates). Note: sync-unix.ts fix from this PR is not in #45 β€” should be a separate PR.

@dhavli dhavli closed this May 18, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants