feat: Map screenshots / images #29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- rename an endpoint - fix the model for screenshot uploads. TODO: - [] map serializer return link for most recent image and all images - [] map serializer return mapfile links
- Add map images to the map serializer. - Test map images return
- Add user_id to file upload model - Some documentation - Stole the file extension getter from the map upload - Add todos for tomorrow. Going to need `BannableObject` sooner rather than later due to circular imports.
- use user id in `CanEdit` to save a query - Add the map image upload endpoint
- fixed issues found via tests - disallow uploads for banned maps, temporary maps, and legacy maps
- Test file size checks
- modify uploaded files to convert to jpeg, slightly shrink, and remove exif - add the cnc_user_id to uploaded files
- make moderabile object - Fix circular imports with file extensions - Fix broken 0002 migration due to the object manager not using the correct schema state
- fix nginx mimetypes for local dev
- move image uploading to its own file
- Add `/maps/img/id` edit endpoint - Add `editable_fields` to serializers, which allows for fields to be set during creation, but never allowed to be updated.
alexlambson
commented
Nov 7, 2025
|
|
||
| # Configurable user setup | ||
| ENV USER=cncnet | ||
| ENV UID=1000 |
Collaborator
Author
There was a problem hiding this comment.
This was causing issues on machines where the user ID of the host didn't match
| alias /usr/share/nginx/html/static/; # The nginx container's mounted volume. | ||
| expires 30d; | ||
| add_header Cache-Control public; | ||
| include /etc/nginx/mime.types; |
Collaborator
Author
There was a problem hiding this comment.
needed to serve files
| from kirovy.models import CncUser | ||
|
|
||
|
|
||
| class Moderabile(models.Model): |
Collaborator
Author
There was a problem hiding this comment.
Yes this is a word
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
map.is_publishedBannableabstract model.Remove the extra hash fields from the file base objectmoved to kanbanescapeall text fieldsAfter merging