Enhancement: better Alpine compatibility#1064
Conversation
statzitz
force-pushed
the
enhancement_alpine_build
branch
from
fd604ef to
d4fd44e
Compare
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/2/input |
statzitz
force-pushed
the
enhancement_alpine_build
branch
from
d4fd44e to
31793f3
Compare
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/3/input |
Related to ClusterLabs#266 Implements the possibility to build pcs for Alpine linux/openrc. There are still lots of works to implements, before being able to say pcs is compatible with openrc, but this is a starting point - Added Alpine's Ruby recognition by improving PCS_PKG_CHECK_VAR (needs review on that) - Formatted PCS_PKG_CHECK_VAR to match the rest of the file (use only tab instead of tab + space for indentation) - Removed the force systemd to also be able to build openrc (inspired partially by ClusterLabs#498) - Added alpine linux as a distribution similar to opencloudos to permits build Please do not hesitate to tells me ways to improve my changes.
statzitz
force-pushed
the
enhancement_alpine_build
branch
from
31793f3 to
b41a706
Compare
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/4/input |
|
I haven't added the tests made in #498 yet as they needs reworking |
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/5/input |
tomjelinek
left a comment
tomjelinek
left a comment
There was a problem hiding this comment.
Hi statzitz,
Thank you for the pull request. In general, it looks good to me. However, there are a few points I'd like to resolve before merging it. Except comments in the code, there are also missing tests for OpenRcDriver class.
Once CI is ready, I'll get the pull request tested.
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/6/input |
They are the ones proposed in ClusterLabs#498, but with some rework so that they pass again
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/7/input |
|
I just added the tests :) |
|
Can one of the project admins check and authorise this run please: https://ci.kronosnet.org/job/pcs/job/pcs-pipeline/job/PR-1064/8/input |
tomjelinek
left a comment
tomjelinek
left a comment
There was a problem hiding this comment.
Thanks, looks good to me. We're still waiting for CI issues to get resolved.
2 participants
Related to #266
Implements the possibility to build pcs for Alpine linux/openrc. There are still lots of works to implements before being able to say pcs is compatible with openrc, but this is a starting point
Please do not hesitate to tells me ways to improve my changes.