This repository was archived by the owner on Jun 7, 2022. It is now read-only.
Added Line 90#324
Open
bnt4 wants to merge 13 commits intoCloudNetService:developmentfrom
bnt4:patch-1
Open
Conversation
Update 2.1.17
Second 2.1.17 Update
Github issue and pull request templates
…-file Create Dependabot config file
Bumps log4j-core from 2.12.1 to 2.13.2. Signed-off-by: dependabot[bot] <support@github.com>
…t-api/cloudnet-api-bridge/org.apache.logging.log4j-log4j-core-2.13.2 Bump log4j-core from 2.12.1 to 2.13.2 in /cloudnet-api/cloudnet-api-bridge
Added the line 90 null check to fix a NullPointerException when a player is disconnecting.
Member
|
Thank you for contributing to CloudNet.
Do your changes break existing APIs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added the line 90 null check to fix a NullPointerException when a player is disconnecting.
This pull request includes:
(?) I don't know what to do here
Changes made to the repository:
I added line 90 to CloudPermissible.java to fix a null pointer exception when disconnecting. It is now returning if the player to recalculate the permissions is not existent.
Documentation of test results:
I did not test it after the change, but I'm very confident that this will fix it.
Error:
Stack Trace
[23:09:42] [Server thread/INFO]: TaskID lost connection: Disconnected [23:09:42] [Server thread/ERROR]: Could not pass event PlayerQuitEvent to FastAsyncWorldEdit v1.16-449;cc5b3ec java.lang.NullPointerException: null at de.dytanic.cloudnet.bridge.internal.util.CloudPermissible.recalculatePermissions(CloudPermissible.java:90) ~[?:?] at org.bukkit.permissions.PermissibleBase.removeAttachment(PermissibleBase.java:161) ~[patched_1.16.4.jar:git-Paper-318] at org.bukkit.craftbukkit.v1_16_R3.entity.CraftHumanEntity.removeAttachment(CraftHumanEntity.java:236) ~[patched_1.16.4.jar:git-Paper-318] at com.sk89q.worldedit.bukkit.BukkitPermissionAttachmentManager.removeAttachment(BukkitPermissionAttachmentManager.java:31) ~[?:?] at com.sk89q.worldedit.bukkit.BukkitPlayer.unregister(BukkitPlayer.java:416) ~[?:?] at com.boydti.fawe.bukkit.FaweBukkit.onPlayerQuit(FaweBukkit.java:271) ~[?:?] at com.destroystokyo.paper.event.executor.asm.generated.GeneratedEventExecutor1920.execute(Unknown Source) ~[?:?] at org.bukkit.plugin.EventExecutor.lambda$create$1(EventExecutor.java:69) ~[patched_1.16.4.jar:git-Paper-318] at co.aikar.timings.TimedEventExecutor.execute(TimedEventExecutor.java:80) ~[patched_1.16.4.jar:git-Paper-318] at org.bukkit.plugin.RegisteredListener.callEvent(RegisteredListener.java:70) ~[patched_1.16.4.jar:git-Paper-318] at org.bukkit.plugin.SimplePluginManager.callEvent(SimplePluginManager.java:607) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.PlayerList.disconnect(PlayerList.java:513) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.PlayerConnection.a(PlayerConnection.java:1677) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.NetworkManager.handleDisconnection(NetworkManager.java:500) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.ServerConnection.c(ServerConnection.java:165) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.MinecraftServer.b(MinecraftServer.java:1381) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.DedicatedServer.b(DedicatedServer.java:377) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.MinecraftServer.a(MinecraftServer.java:1209) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.MinecraftServer.w(MinecraftServer.java:997) ~[patched_1.16.4.jar:git-Paper-318] at net.minecraft.server.v1_16_R3.MinecraftServer.lambda$a$0(MinecraftServer.java:178) ~[patched_1.16.4.jar:git-Paper-318] at java.lang.Thread.run(Thread.java:834) [?:?]