Remove deprecated cloud service client command#148
Open
sdairs wants to merge 3 commits into
Open
Conversation
`cloud service query` now covers the cloud query path over HTTP without needing a local clickhouse binary or service password, so the `cloud service client` subcommand and its binary-download helper are no longer needed. Closes #147. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
rpassword 7.5.0 referenced `libc::__errno_location` (Linux-only), which broke `cargo build` on macOS. 7.5.2 restores macOS support. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
README still framed `cloud service query` as the successor to `cloud service client` on a deprecation path, and the cloud service CONTEXT FOR AGENTS pointed at `client`. Rewrite both to stand on their own. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
cloud service clientsubcommand:cloud service querynow covers the cloud query path over HTTP without needing a local clickhouse binary or service password.ensure_version_installed()that downloaded the matching ClickHouse binary just forcloud service client.rpassword7.5.0 → 7.5.2 (separate commit) to unblock macOS builds — 7.5.0 referenced the Linux-onlylibc::__errno_location.Closes #147.
Note
Based on #146 so it merges clean once that lands. Retarget to
mainafter #146 merges.Test plan
cargo build(workspace, macOS)cargo test(249 passed)cargo clippy -p clickhousectl --all-targets(no new warnings)is_write_command_read_only_commandsstill passes with the variant gone🤖 Generated with Claude Code