fix: image tag in installer, changelog categories, main build images versions#124
fix: image tag in installer, changelog categories, main build images versions#124GrigoryPervakov merged 1 commit intomainfrom
Conversation
3249bb5 to
e28c6bd
Compare
a63f356 to
f8a331a
Compare
There was a problem hiding this comment.
Pull request overview
This PR updates the build/release tooling so installer and container images are versioned/tagged correctly (including latest), and so the release changelog categories are explicitly configured.
Changes:
- Derive
FULL_VERSIONin the Makefile and propagate it into build/linker flags and docker build args. - Add a
docker-buildx-latesttarget and switch release workflows to use it to publish alatesttag. - Replace the release “Kustomize Build” step with
make build-installerand add explicit changelog-builder category configuration.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
Makefile |
Introduces FULL_VERSION, threads it into build/linker flags, and adds docker-buildx-latest for tagging latest. |
Dockerfile |
Adjusts ldflags to use the provided VERSION arg as-is (no extra v prefix). |
.github/workflows/release.yaml |
Uses docker-buildx-latest, builds installer via Make, and adds changelog category config. |
.github/workflows/release-main.yml |
Switches main-branch image publishing to docker-buildx-latest. |
.github/workflows/ci.yaml |
Pins VERSION in the bundle job environment. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
f8a331a to
b97c67d
Compare
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
Why
Current behavior builds an installer with a hardcoded v0.0.1 tag.
Default config matches only
feature,fixandtestlabelsMain build result on images with version 'vlatest'
The release image is not tagged as the latest
What
Call the correct script to generate the installer
Add explicit configuration for changelog builder
Generate version for main branch builds