Add remaining HTTP setting typings#785
Open
popsiclelmlm wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #53.
Adds explicit
ClickHouseSettingstypings for several HTTP query parameters that ClickHouse handles outside the regular server settings set.Reproduction
Before this change, these HTTP parameters could still be passed because
ClickHouseSettingsallows arbitrary keys, but TypeScript users did not get autocomplete or documentation for them.Root cause
ClickHouseHTTPSettingsonly listed part of the HTTP-specific parameter surface.Changes
quota_key,stacktrace,buffer_size, andclose_session.buffer_sizeis deprecated in favor ofhttp_response_buffer_size.Tests
git diff --checknpm --workspace @clickhouse/client-common run typechecknpm --workspace @clickhouse/client-common run lintChangelog
@clickhouse/client-common: add typings for additional HTTP settings.