Drop sub-seconds for DateTime query params while preserving DateTime64 precision#777
Draft
Copilot wants to merge 2 commits into
Draft
Drop sub-seconds for DateTime query params while preserving DateTime64 precision#777Copilot wants to merge 2 commits into
Copilot wants to merge 2 commits into
Conversation
|
|
Copilot
AI
changed the title
[WIP] Fix serialization of Date objects with non-zero milliseconds
Drop sub-seconds for DateTime query params while preserving DateTime64 precision
May 29, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Datequery params are serialized as fractional Unix timestamps (e.g.1742553000.500) whenever milliseconds are non-zero.DateTime/DateTime32reject the fractional part (Value ... cannot be parsed as DateTime ... isn't parsed completely), whileDateTime64requires it. SinceformatQueryParamsonly saw the value, it could not pick the right encoding (#628).The client now infers the declared parameter type from the query's
{name:Type}placeholder and drops the sub-second part only for second-precision types, keeping it forDateTime64.Changes
format_query_params.ts:formatQueryParamsaccepts an optionaltype;shouldTruncateDateToSecondstruncates when the type matches/DateTime/but not/DateTime64/. Threaded through arrays/tuples/maps so nestedDates follow the container type. Unknown type → previous millisecond behavior (no regression).url.ts:toSearchParamsparses each param's type from the query (getQueryParamType, whitespace-tolerant, regex-escaped name) and forwards it. Added aquery_in_urlflag to decouple type detection from URL inclusion — passing the SQL in both the URL and the body makes the server concatenate and reject it.query()/webexec()passquerywithquery_in_url: false; noderunExecgates URL inclusion onsendQueryInParams.Checklist