Make TypeScript sources compatible with --erasableSyntaxOnly#768
Draft
Copilot wants to merge 1 commit into
Draft
Make TypeScript sources compatible with --erasableSyntaxOnly#768Copilot wants to merge 1 commit into
Copilot wants to merge 1 commit into
Conversation
Copilot created this pull request from a session on behalf of
peter-leonov-ch
May 29, 2026 13:01
View session
|
|
peter-leonov-ch
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all TypeScript-only syntax extensions that emit runtime code, so the project can be built/typechecked with
--erasableSyntaxOnly(and consumed by runtimes like Node's native TS stripping). The option is enabled intsconfig.base.jsonto lock this in.as constobject + type alias. PreservesFoo.Barmember access and runtime values. Applied to the publicClickHouseLogLeveland to internal/test enums (TestEnv,TestConnectionType, local test enums inselect_query_binding.test.ts).TupleParam,SettingsMap,LogWriter,WebConnection, web/nodeResultSet,NodeBaseConnection,SocketPool, and theBufferReadertest helper.ClickHouseLogLevel[this.logLevel](used for the startup log message) is replaced by a derivedClickHouseLogLevelNamereverse map; output is unchanged.tsconfig.base.json:"erasableSyntaxOnly": true.Example of the enum transform — call sites such as
ClickHouseLogLevel.TRACEcontinue to work:No namespaces or
import = require(...)exist in the tree, so nothing else needed to change.Checklist
CHANGELOG
--erasableSyntaxOnlycompiler option.ClickHouseLogLevelis now exported as aconstobject plus a union type instead of a TSenum; runtime values andClickHouseLogLevel.TRACE-style member access are unchanged.