Update the async_insert_busy_timeout_ms
#508
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshustov
reviewed
Jan 8, 2026
| * | ||
| * @see https://clickhouse.com/docs/operations/settings/settings#async_insert_busy_timeout_max_ms | ||
| */ | ||
| async_insert_busy_timeout_max_ms?: Milliseconds |
Member
There was a problem hiding this comment.
how did you catch it? IIRC This file was generated from https://github.com/ClickHouse/ClickHouse/blob/master/src/Core/Settings.cpp. I wonder how we can keep it up-to-date
mshustov
approved these changes
Jan 8, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The
async_insert_busy_timeout_msconfig option is not anymore present in the docs. The description matches though the more specific config optionasync_insert_busy_timeout_max_ms.Changing both the doc link and the option name.
Please let me know if we want to first deprecate the old config option.