Skip to content

Conversation

@punkbit
Copy link
Collaborator

@punkbit punkbit commented Jan 23, 2026

Why?

To accomodate request to use single quotes instead of double quotes.

How?

  • Modify eslint config
  • Update prettier rules

Preview?

Screenshot 2026-01-23 at 16 00 04

@changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2026

⚠️ No Changeset found

Latest commit: 21caea1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Jan 23, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
click-ui Ready Ready Preview, Comment Jan 23, 2026 6:24pm

Request Review

@@ -4,12 +4,12 @@ const theme = {
sm: {
icon: {
size: {
height: "1rem",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not be edited like this
You need to the style dictionary inorder to accomadate changes which we create using build-tokens

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vineethasok the linter and formatter process files in src/*.

What you're seeing here is the result of the computations provided by the linter and formatter of the team's choice!

Any file placed in the directories, which might or not exclusively generate in the context of the project, such as external sources, whether that be Figma, your text editor, or others, once stored in the project, will be processed accordingly. That's what a formatter and linter processes do: you set rules, and it computes them.

If any directories or files should be an exception, then that has to be declared.

But it seems unnecessary to point this out due to the generated files working in any of the preferred formats, which, at the moment, was decided by @hoorayimhelping request to be single-quote. Conversely, for double quotes, the linter would show a linter warning from now on, and every time the file is placed in the project.

Which once "lint:fix: is fixed into the rules chosen. So, this is not exactly a problem.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants