Fix snapshot config selection#111
Open
antonio2368 wants to merge 2 commits into
Open
Conversation
1 task
antonio2368
added a commit
to ClickHouse/ClickHouse
that referenced
this pull request
May 25, 2026
`KeeperStateMachine` now persists and restores the committed cluster config separately from the latest `NuRaft` config. `KeeperServer` chooses the newest valid config from snapshot, committed store, or logs bounded by the committed or snapshot index, so restart after rollback and compaction cannot apply uncommitted membership. `KeeperLogStore` exposes cutoff-aware config lookup and `contrib/NuRaft` is bumped to PR `111`, which fixes snapshot config selection in `raft_server::snapshot_and_compact`. NuRaft PR: ClickHouse/NuRaft#111 CI: https://s3.amazonaws.com/clickhouse-test-reports/json.html?PR=105784&sha=651ec2e7736bce8974e0c7046a6e267b04bacb4f&name_0=PR&name_1=Fast%20test ClickHouse PR: #105784
Reject empty or future configs when choosing snapshot metadata, fall back to a valid committed/current config where possible, and refresh target priority when skipping stale config commits.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.