Skip to content

Full native ast coverage#19

Merged
alex-clickhouse merged 2 commits intomainfrom
full-native-ast-coverage
Mar 11, 2026
Merged

Full native ast coverage#19
alex-clickhouse merged 2 commits intomainfrom
full-native-ast-coverage

Conversation

@alex-clickhouse
Copy link
Collaborator

No description provided.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR expands Native-format AST generation/traversal so that protocol/metadata bytes (headers, serialization kinds, terminal blocks, etc.) are represented in the AST and included in byte-coverage checks.

Changes:

  • Add explicit AST nodes for Native block headers, column metadata, serialization metadata, and per-column “prefix” protocol nodes.
  • Track and surface terminal “end block” bytes via ParsedData.trailingNodes, and include them in UI traversal and coverage analysis.
  • Strengthen Native coverage testing by asserting full byte coverage (and adding a protocol-revision coverage matrix).

Reviewed changes

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/store/store.ts Ensures “expand all” includes newly added Native AST nodes + trailing nodes.
src/core/types/ast.ts Extends Native AST-related types with explicit nodes and trailingNodes.
src/core/decoder/test-helpers.ts Updates byte coverage analysis to include Native header/meta/prefix/trailing nodes.
src/core/decoder/native-protocol.test.ts Adds byte-coverage assertions and a terminal-block coverage test.
src/core/decoder/native-decoder.ts Emits full-fidelity AST for Native protocol metadata and exposes trailing terminal-block nodes.
src/core/decoder/coverage.integration.test.ts Adds a protocol-revision × query coverage matrix expecting full coverage.
src/components/HexViewer/HexViewer.tsx Switches Native highlighting/selection traversal to AST-driven header/meta/prefix/trailing nodes.
src/components/AstTree/AstTree.tsx Switches Native block/column metadata rendering to AST-driven nodes and displays trailing nodes.
README.md Documents protocol version selection and testing stack.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alex-clickhouse alex-clickhouse merged commit d803d0c into main Mar 11, 2026
5 checks passed
@alex-clickhouse alex-clickhouse deleted the full-native-ast-coverage branch March 11, 2026 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants