Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR expands Native-format AST generation/traversal so that protocol/metadata bytes (headers, serialization kinds, terminal blocks, etc.) are represented in the AST and included in byte-coverage checks.
Changes:
- Add explicit AST nodes for Native block headers, column metadata, serialization metadata, and per-column “prefix” protocol nodes.
- Track and surface terminal “end block” bytes via
ParsedData.trailingNodes, and include them in UI traversal and coverage analysis. - Strengthen Native coverage testing by asserting full byte coverage (and adding a protocol-revision coverage matrix).
Reviewed changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/store/store.ts | Ensures “expand all” includes newly added Native AST nodes + trailing nodes. |
| src/core/types/ast.ts | Extends Native AST-related types with explicit nodes and trailingNodes. |
| src/core/decoder/test-helpers.ts | Updates byte coverage analysis to include Native header/meta/prefix/trailing nodes. |
| src/core/decoder/native-protocol.test.ts | Adds byte-coverage assertions and a terminal-block coverage test. |
| src/core/decoder/native-decoder.ts | Emits full-fidelity AST for Native protocol metadata and exposes trailing terminal-block nodes. |
| src/core/decoder/coverage.integration.test.ts | Adds a protocol-revision × query coverage matrix expecting full coverage. |
| src/components/HexViewer/HexViewer.tsx | Switches Native highlighting/selection traversal to AST-driven header/meta/prefix/trailing nodes. |
| src/components/AstTree/AstTree.tsx | Switches Native block/column metadata rendering to AST-driven nodes and displays trailing nodes. |
| README.md | Documents protocol version selection and testing stack. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.