Upgrade to Node 10 #75
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prime-time
reviewed
Oct 14, 2019
lib/understream.coffee
Outdated
| debug "_read #{size} #{JSON.stringify @arr[@index]}" | ||
| @push @arr[@index] # Note: push(undefined) signals the end of the stream, so this just works^tm | ||
| data = @arr[@index] | ||
| if data is undefined |
Contributor
There was a problem hiding this comment.
Another option would be to push null if @index > @arr.length - 1 and that would allow reading undefined values from the stream. I'm not sure if we'd actually want that though.
Contributor
Author
There was a problem hiding this comment.
Yeah I'm not sure either 🤔
Contributor
Author
There was a problem hiding this comment.
I think we should.. adding that change
Contributor
|
It looks like there's a pull request open for v1 #40 0.10 to 0.11 seems like the right version bump to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure if this should be a major version bump, as it's currently not even 1.0.0