Adding a bunch of ebay rules#198
Draft
Gymcap wants to merge 3 commits into
Draft
Conversation
I just went and browsed ebay for a while and added anything that didn't appear to effect the destination
LH_ItemCondition is used to keep track of the condition (i.e. new/used/refurbished) being searched for, and should be kept in tact, my mistake
reordering, as to leave previous rules unchanged
Contributor
Author
|
I'm pretty sure this is wrong because I put it in the default branch, I haven't had the time to fix this but I will try to soon. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ClearURLs had been lacking on ebay for some time, so I took it upon myself to add as much as I could remove while browsing, without affecting my intended destinations.
Added:
Examples like the following url can occur on any search or product page depending on context like previous pages visited, clicks, etc.
https://www.ebay.com/itm/236817343777?_skw=google%20pixel%20unlocked%205g&epid=4085693631&itmmeta=01KRN2CCBSDNH1J5Y7VPGXT1B9&itmprp=enc%3AAQALAAAA8GfYFPkwiKCW4ZNSs2u11xA2XQxfV6h0OqNL13XiZmv9uVGssq%2B6V0kcyf3G2KsiaQ9cqiSxaNKevfkpRqCZsOgvkMXBlA17xBPAHGX7XWo4h%2F2FXJG1FzCTMcSn46h0LBwUoRTNwiUR92owE6JuOCcg2CfrOwxK6%2FKDrRDRq0poQL0NBbYYF2kxMXqzUw8F5vLds4YhM1cWkWmPB0c5cBKrlryZ7Sm2ds4DzTx0Jr3OiTIDDjYPC6a2FUvnkAsadp5%2BRVdrRTIlvMIOwQ4PgxJqIO2rUYojwur2O0v3s%2B9p3GKxXonNfqW20jaq6oe8xw%3D%3D|tkp%3ABk9SR4zHsaLFZw
Added:
Unsure what this does, but it seems to have nothing to do with loading the page.
https://www.ebay.com/sch/i.html?_nkw=rubber+bands&_sacat=0&_from=R40&_trksid=p2334524.m570.l1313
Added:
I found examples like the following url when browsing shop pages. Removing it changes seemingly nothing.
https://www.ebay.com/sch/i.html?item=397922594342&rt=nc&_trksid=p4429486.m145687.l2562&_ssn=madyma_0