Fix. Code. Improve statement.#804
Conversation
Codecov Report❌ Patch coverage is ❌ Your patch check has failed because the patch coverage (11.11%) is below the target coverage (70.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## dev #804 +/- ##
============================================
- Coverage 25.93% 25.93% -0.01%
- Complexity 5612 5621 +9
============================================
Files 264 264
Lines 24117 24124 +7
============================================
+ Hits 6255 6256 +1
- Misses 17862 17868 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Pull request overview
This PR hardens several security-sensitive paths in the anti-spam plugin, including support-user credential generation, UA blacklist matching, CSV export escaping, localhost-only debug user insertion, and cron option unserialization.
Changes:
- Replaces weak random generation for support-user login/password paths.
- Adds UA regex delimiter escaping and CSV formula/field escaping.
- Restricts debug AJAX user insertion to localhost and tightens cron task unserialization.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
lib/Cleantalk/Common/SupportUser.php |
Uses stronger randomness for support-user credentials. |
lib/Cleantalk/ApbctWP/Firewall/AntiCrawler.php |
Hardens UA blacklist regex construction/error handling. |
lib/Cleantalk/ApbctWP/FindSpam/UsersChecker.php |
Adds CSV field escaping and localhost guard for debug user insertion. |
lib/Cleantalk/ApbctWP/Cron.php |
Validates and restricts cron option unserialization. |
inc/cleantalk-find-spam.php |
Registers debug user insertion AJAX action only on localhost. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
task https://app.doboard.com/1/task/48216