Skip to content

Fix. Settings. React - Settings Api key implemented.#613

Open
Glomberg wants to merge 47 commits intodevfrom
react-settings-tab.ag
Open

Fix. Settings. React - Settings Api key implemented.#613
Glomberg wants to merge 47 commits intodevfrom
react-settings-tab.ag

Conversation

@Glomberg
Copy link
Member

alexandergull and others added 30 commits January 31, 2026 21:56
# Conflicts:
#	js/public/spbct-react-bundle.js
# Conflicts:
#	js/public/spbct-react-bundle.js
…Rebuld-to-react-VI

# Conflicts:
#	css/spbc-admin.min.css
#	css/spbc-dashboard-widget.min.css
#	css/spbc-icons.min.css
#	css/spbc-public.min.css
#	css/spbc-settings-media.min.css
#	css/spbc-settings.min.css
#	css/spbc-table.min.css
#	css/spbc-timeline-widget.min.css
…react-VI' into react-settings-tab.ag

# Conflicts:
#	css/spbc-admin.min.css
#	css/spbc-dashboard-widget.min.css
#	css/spbc-icons.min.css
#	css/spbc-public.min.css
#	css/spbc-settings-media.min.css
#	css/spbc-settings.min.css
#	css/spbc-table.min.css
#	css/spbc-timeline-widget.min.css
#	inc/spbc-admin.php
#	js/public/spbct-react-bundle.js
#	js/src/react/components/SettingsOverview/SettingsOverview.js
#	js/src/react/components/TabContent/TabSettingsGeneral/TabSettingsGeneral.js

const importExportHandler = (e) => {
e.preventDefault();
spbcModal.open().load('spbc_get_options_template')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is spbcModal exist?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<span dangerouslySetInnerHTML={{
__html: sprintf(
__('Admin e-mail %s will be used for registration', 'security-malware-firewall'),
`<span id="spbc-account-email">${adminEmail}</span>`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

potential xss, escape this value $adminEmail

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

style={{fontSize: '14pt'}}
/>;

const getKeyManualLink = `https://cleantalk.org/register?platform=wordpress&email=${adminEmail}&website=${window.location.hostname}&product_name=security&utm_source=admin_side&utm_medium=get_access_key_button&utm_campaign=spbct_links`;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably sanitize adminemail and window location before output to exclude XSS attacks

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants