Skip to content
This repository was archived by the owner on Nov 15, 2021. It is now read-only.

Conversation

@jseagrave21
Copy link
Contributor

What current issue(s) does this address, or what feature is it adding?

How did you solve this problem?

  • searched for logzero imports
  • replaced with log_manager where necessary: Transaction.py & Send.py
  • completed manual testing to verify expected result

How did you make sure your solution works?
manual testing

NOTE: I don't think I can add individual unittests for this issue because running make test displays every level of logger.

Are there any special changes in the code that we should be aware of?
no

Please check the following, if applicable:

  • Did you add any tests?
  • Did you run make lint?
  • Did you run make test?
  • Are you making a PR to a feature branch or development rather than master?
  • Did you add an entry to CHANGELOG.rst? (if not, please do)

jseagrave21 added 2 commits May 29, 2019 23:20
- searched for logzero imports
- replaced with log_manager where necessary: Transaction.py & Send.py
- completed manual testing to verify expected result
@coveralls
Copy link

Coverage Status

Coverage increased (+0.001%) to 85.052% when pulling 0893489 on jseagrave21:rm-logzero-2 into c95fec6 on CityOfZion:development.

@ixje
Copy link
Member

ixje commented May 30, 2019

thanks!

@ixje ixje merged commit f36d328 into CityOfZion:development May 30, 2019
@jseagrave21 jseagrave21 deleted the rm-logzero-2 branch May 30, 2019 10:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants