This repository was archived by the owner on Nov 15, 2021. It is now read-only.
Update/Add Asset and Contract Search Methods #667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
Merge CoZ Development into jseagrave21 Development
* Update ExtendedJsonRpcApi.py - add fix provided by @localhuman so original methods are returned as well as extended methods
…yOfZion#661) * Add the option -u (unittest-net) to prompt.py * Add unittest guildeline and add the smart contract source codes (UnitTest-SM.zip) to the fixtures package
- allow 'neo' and 'gas' to be used for `getassetstate`
- add test for `getassetstate` using string
- Add `ShowAllAssets` Function
- remove numbering - add test for `ShowAllAssets`
- update `help` to for `asset all` and `contract all` - add the ability to show all assets with `asset all`
- add `searchcontracts`, `showallassets`, `showallcontracts`
- add exception for "No known contracts" to `searchcontracts`
- add tests for `showallassets`, `showallcontracts`, `searchcontracts`
- remove indentation
for compatibility
for compatibility
- re-add methods
This reverts commit 85d0336.
This reverts commit 6ed8141.
Revert "Merge CoZ Development into jseagrave21 AssetState-Updates"
for compatibility
for compatibility
Merge CoZ Development into jseagrave21 AssetState_Updates
- re-add methods
- import required modules
- remove indentation
- add 'gas' test for `getassetstate`
Collaborator
|
Looks good, though merge conflicts will need to be fixed! |
for compatibility
for compatibility
Merge CoZ development into jseagrave21 AssetState-Updates
- re-add test removed to resolve conflicts
Contributor
Author
|
@localhuman Okay, this PR is ready for another review. |
- remove unnecessary `list()`s
ixje
suggested changes
Nov 14, 2018
Member
ixje
left a comment
ixje
left a comment
There was a problem hiding this comment.
Note to self; split extended functionality and base functionality. Ping PR author when Extended plugin changes are ready
This was referenced Dec 4, 2018
Closed
Member
|
If you can remove the extended RPC related code (as that was moved out now see #756) then we can still use it to update the other parts. Thanks! |
- remove Extended methods per CityOfZion#667 (comment)
- remove tests per CityOfZion#667 (comment)
- update `show_asset_state` and `show_contract_state` per changes in CityOfZion#741 and CityOfZion#739
for compatibility
Merge CoZ development into jseagrave21 AssetState-Updates
- update tests
- update SearchAssetState per CityOfZion#739
Contributor
Author
|
@ixje this PR should be ready to go |
Member
|
Strange that I did not get a web notification. I happened to look at my email and saw that there should be updates. Thanks again 👍 |
ixje
approved these changes
Dec 23, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What current issue(s) does this address, or what feature is it adding?
-update-
getassetstateRPC methodshowallassetsLevelDBBlockchain functionshowallassetsreturns a list of all asset hashesSearchAssetStateLevelDBBlockchain function per [refactor prompt] Add support for search method group #739helpshow_asset_stateandshow_contract_stateper [refactor prompt] Add support for show method group (pt 2) #741How did you solve this problem?
trial and error
The inspiration for this PR comes from my work on the neo-python API reference. In most cases, assets in neo-python can be searched by their name. The contract search methods update was inspired through their tangential relationship in
prompt.pyand LevelDBBlockckchain.How did you make sure your solution works?
unittest
Are there any special changes in the code that we should be aware of?
No
Please check the following, if applicable:
make lint?make test?CHANGELOG.rst? (if not, please do)