[Strawberry Shake] Fix @rename directive on input type fields

[waldemarsson]

First time contributor trying to fix an issue that's affecting me and some others.

Fixes #8934

@rename on input type fields was silently ignored by the code generator, so fields like equals would generate public string Equals { get; } — a member that shadows object.Equals — causing a CS0102 compiler error with no way to work
around it.

Two bugs in SchemaHelper.Load() were responsible:

1. InputObjectTypeExtensionNode was silently discarded When a schema extensions file contains a SchemaExtensionNode, the file takes the "extension document" branch. That branch handled ScalarTypeExtensionNode, EnumTypeExtensionNode,
   ObjectTypeExtensionNode, etc. — but not InputObjectTypeExtensionNode. Any extend input block (where @rename typically lives) was dropped without error.

2. RenameDirectiveType was never registered with the schema builder DocumentAnalyzer looks up @rename via field.Directives.FirstOrDefault(), which matches on DirectiveType.RuntimeType == typeof(RenameDirective). Because
   RenameDirectiveType was never registered, all @rename directives had RuntimeType = typeof(object) and the lookup always returned null.

A third related fix prevents a SchemaException when the user's schema SDL also declares directive @rename(...) — those declarations are now filtered from non-extension documents before AddDocument() since we always register
RenameDirectiveType programmatically.

Tests added:

• Unit tests in SchemaHelperTests for both fixes and the duplicate declaration guard
• Snapshot test: input field renamed via extension generates the correct C# property name with the original wire key preserved
• Snapshot test: enum value with @rename generates the correct C# member name

[CLAassistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.

---

GitHub Copilot seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[Copilot]

Pull request overview

This PR fixes Strawberry Shake’s schema-loading path so the @rename directive is honored on input type fields (especially when applied via extend input ...), preventing generated C# member-name collisions like Equals.

Changes:

• Forward InputObjectTypeExtensionNode definitions from extension documents into the schema builder so extended input fields aren’t dropped.
• Register RenameDirectiveType in SchemaHelper.Load() and filter user-declared directive @rename(...) from SDL documents to avoid duplicate directive-type errors while ensuring correct CLR binding.
• Add unit and snapshot coverage for input-field rename via extension and enum-value rename.

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file

File	Description
src/StrawberryShake/CodeGeneration/src/CodeGeneration/Utilities/SchemaHelper.cs	Forwards input extensions, registers RenameDirectiveType, and filters SDL @rename directive declarations to prevent duplicates.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.Tests/Utilities/SchemaHelperTests.cs	Adds unit tests covering input-extension forwarding, typed @rename resolution, and duplicate directive declaration handling.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/InputGeneratorTests.cs	Adds snapshot test asserting input field rename via extension impacts generated C# property name while preserving wire key.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/SchemaGeneratorTests.cs	Adds snapshot test for enum value rename producing renamed C# member names while preserving original wire values.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/snapshots/InputGeneratorTests.Input_Field_Renamed_Via_Extension_Has_CSharp_Property_Name_With_Original_Wire_Key.snap	New snapshot baseline for the renamed input-field generation output.
src/StrawberryShake/CodeGeneration/test/CodeGeneration.CSharp.Tests/snapshots/SchemaGeneratorTests.Enum_Value_With_Rename_Has_Renamed_CSharp_Member_And_Original_Wire_Value.snap	New snapshot baseline for enum-value rename generation output.

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.