hal_ee24xx: add bus frequency parameter #427
Merged
+12
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for configurable I2C bus frequency to the hal_ee24xx EEPROM driver to enable proper calculation of write timeouts. The change allows users to specify the bus frequency through configuration rather than relying on a hardcoded value.
Key changes:
- Added
bus_hzparameter toI2CEepromFileConfigstructure - Modified timeout calculation to use configurable frequency with fallback to default
- Updated function signatures to pass bus frequency parameter
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| os/hal/src/hal_ee24xx.c | Updated timeout calculation logic and function signatures to support configurable bus frequency |
| os/hal/include/hal_ee24xx.h | Added bus_hz field to configuration structure with documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
fpoussin
force-pushed
the
i2c_eeprom_freq
branch
from
a6d1396 to
2c04fcc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a way to handle different bus frequencies.
This is needed to calculate the write timeout.
Fixes #379