Skip to content

fix: replace bare except with except BaseException in token_create #905

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
harshadkhetpal wants to merge 1 commit into
base: master
Choose a base branch
from
+1 −1
Open

fix: replace bare except with except BaseException in token_create #905

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmk/gui/dashboard/api/token_create.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ def create_dashboard_token_v1(
dashboard["public_token_id"] = token.token_id
try:
save_dashboard_to_file(api_context.config.sites, dashboard, body.dashboard_owner)
except:
except BaseException:
# rollback token creation
token_store.delete(token.token_id)
raise
Expand Down
Loading