Skip to content

Conversation

@cx-ricardo-jesus
Copy link
Contributor

Reason for Proposed Changes

  • Currently, the query Secret Without Expiration Date returns a misleading result, stating that a resource of type Microsoft.Security/securityContacts should have attributes.exp property id defined, but the resource that this query is tackling is actually Microsoft.KeyVault/vaults/secrets

Proposed Changes

  • Changed the keyActualValue and keyExpectedValue to mention resources of type Microsoft.KeuVault/vaults/secrets.
  • Simplified the query to have only one policy. The query does the same verifications as before.

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner January 26, 2026 10:07
@github-actions github-actions bot added the query New query feature label Jan 26, 2026
@github-actions
Copy link
Contributor

kics-logo

KICS version: v2.1.18

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

query New query feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant