Skip to content

fix(queries): fixed results on queries that had unhandled %s #7950

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cx-ricardo-jesus wants to merge 9 commits into
base: master
Choose a base branch
from
Open

fix(queries): fixed results on queries that had unhandled %s #7950

cx-ricardo-jesus wants to merge 9 commits into from

Conversation

@cx-ricardo-jesus
Copy link
Contributor

@cx-ricardo-jesus cx-ricardo-jesus commented Jan 20, 2026 •
edited
Loading

Closes #

Reason for Proposed Changes

  • Currently, some queries are not handling %s with sprintf functions.

Proposed Changes

  • Query Website Azure Active Directory Disabled for AzureResourceManager:
    • simplified the query to have just one policy.
    • added one positive test, positive7.tf, which covers the cases when the field identity.type is defined to UserAssigned without the field identity.userAssignedIdentities defined.
    • removed unnecessary %s.
  • Query API Gateway With Invalid Compression for CloudFormation/AWS:
    • simplified query to have just one policy.
    • added sprintf to handle %s.
  • Query ALB Listening on HTTP for Alicloud:
    • added sprintf to handle %s.
  • Query API Gateway Access Logging Disabled for Terraform/AWS:
    • added sprintf to handle %s.
  • Query Serverless API Without Content Encoding for Cloudformation/AWS_SAM:
    • added sprintf to handle %s.
    • simplified query to have just one policy.

I submit this contribution under the Apache-2.0 license.

@cx-ricardo-jesus cx-ricardo-jesus requested a review from a team as a code owner January 20, 2026 16:10
@cx-ricardo-jesus cx-ricardo-jesus marked this pull request as draft January 20, 2026 16:11
@github-actions github-actions bot added the query New query feature label Jan 20, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 20, 2026

kics-logo

KICS version: v2.1.18

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-ricardo-jesus cx-ricardo-jesus marked this pull request as ready for review January 21, 2026 12:35
@github-actions github-actions bot added cloudformation CloudFormation query alicloud terraform Terraform query azure PR related with Azure Cloud aws PR related with AWS Cloud labels Jan 21, 2026
cx-artur-ribeiro
cx-artur-ribeiro approved these changes Jan 21, 2026
View reviewed changes
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice job Ricardo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro approved these changes

Assignees

@cx-ricardo-jesus cx-ricardo-jesus

Labels

alicloud aws PR related with AWS Cloud azure PR related with Azure Cloud cloudformation CloudFormation query query New query feature terraform Terraform query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cx-ricardo-jesus @cx-artur-ribeiro