-
Notifications
You must be signed in to change notification settings - Fork 357
fix(analyzer): add unwanted channel drain before done channel returns for correct line count #7942
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
…he all excluded files to be taken into consideration
cx-rui-araujo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@cx-artur-ribeiro check my comment please
…n to use maps.keys
cx-rui-araujo
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pal
cx-eduardo-semanas
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM








Reason for Proposed Changes
wg.Wait()), the channels are closed and a done signal is sent. However, thecomputeValues()function uses a select statement that races between reading messages from unwanted and receiving the done signal.Proposed Changes
unwantedchannel before exiting;ListSupportedCloudProvidersto matchListSupportedPlatforms()implementation, reducing tech dept and automatically fetch supported cloud providers from the constants;I submit this contribution under the Apache-2.0 license.