Skip to content

fix(bug): improve helm scanning for empty files and duplicated results #7937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cx-miguel-dasilva wants to merge 8 commits into
base: master
Choose a base branch
from
Open

fix(bug): improve helm scanning for empty files and duplicated results #7937

cx-miguel-dasilva wants to merge 8 commits into from

Conversation

@cx-miguel-dasilva
Copy link
Collaborator

@cx-miguel-dasilva cx-miguel-dasilva commented Jan 7, 2026 •
edited
Loading

Proposed Changes

  • Remove empty files from Helm chart rendering that cause parsing errors
  • Remove duplicated vulnerabilities during scanning for Helm charts, which may be found when a parse error occurs from double file scanning. One for the Raw k8s file and the Helm rendered file

I submit this contribution under the Apache-2.0 license.

@cx-miguel-dasilva cx-miguel-dasilva self-assigned this Jan 7, 2026
@github-actions github-actions bot added bug Something isn't working kubernetes Kubernetes query labels Jan 7, 2026
@github-actions
Copy link
Contributor

github-actions bot commented Jan 7, 2026

kics-logo

KICS version: v2.1.18

Category Results
CRITICAL CRITICAL 0
HIGH HIGH 0
MEDIUM MEDIUM 0
LOW LOW 0
INFO INFO 0
TRACE TRACE 0
TOTAL TOTAL 0
Metric Values
Files scanned placeholder 1
Files parsed placeholder 1
Files failed to scan placeholder 0
Total executed queries placeholder 47
Queries failed to execute placeholder 0
Execution time placeholder 0

@cx-miguel-dasilva cx-miguel-dasilva changed the title fix(bug): add filtering to duplicated k8s & helm results fix(bug): improve helm scaning for empty fiels and duplcated results Jan 8, 2026
@cx-miguel-dasilva cx-miguel-dasilva changed the title fix(bug): improve helm scaning for empty fiels and duplcated results fix(bug): improve helm scanning for empty files and duplicated results Jan 8, 2026
@cx-miguel-dasilva cx-miguel-dasilva marked this pull request as ready for review January 8, 2026 16:09
@cx-miguel-dasilva cx-miguel-dasilva requested a review from a team as a code owner January 8, 2026 16:09
cx-eduardo-semanas
cx-eduardo-semanas previously approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@cx-eduardo-semanas cx-eduardo-semanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cx-artur-ribeiro
cx-artur-ribeiro previously approved these changes Jan 8, 2026
View reviewed changes
Copy link
Contributor

@cx-artur-ribeiro cx-artur-ribeiro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cx-bruno-silva
cx-bruno-silva reviewed Jan 8, 2026
View reviewed changes
cx-rui-araujo
cx-rui-araujo previously approved these changes Jan 9, 2026
View reviewed changes
Copy link
Contributor

@cx-rui-araujo cx-rui-araujo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@cx-bruno-silva cx-bruno-silva cx-bruno-silva approved these changes

@cx-eduardo-semanas cx-eduardo-semanas cx-eduardo-semanas left review comments

@cx-rui-araujo cx-rui-araujo cx-rui-araujo left review comments

@cx-artur-ribeiro cx-artur-ribeiro cx-artur-ribeiro left review comments

Assignees

@cx-miguel-dasilva cx-miguel-dasilva

Labels

bug Something isn't working kubernetes Kubernetes query

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@cx-miguel-dasilva @cx-bruno-silva @cx-eduardo-semanas @cx-rui-araujo @cx-artur-ribeiro