-
Notifications
You must be signed in to change notification settings - Fork 357
feat(query): implemented query that ensures that kubernetes web ui is disabled (field deprecated) #7879
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
cx-ricardo-jesus
wants to merge
17
commits into
master
Choose a base branch
from
AST-121534
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+146
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… disabled (field deprecated)
Contributor
…isabled bases on gke version
cx-miguel-dasilva
requested changes
Jan 22, 2026
Collaborator
cx-miguel-dasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @cx-ricardo-jesus,
Nice detail on query logic and version specifics. Great Work!
Please take a look at my comments.
assets/queries/terraform/gcp/kubernetes_web_ui_is_not_disabled/test/negative3.tf
Outdated
Show resolved
Hide resolved
assets/queries/terraform/gcp/kubernetes_web_ui_is_not_disabled/test/positive2.tf
Outdated
Show resolved
Hide resolved
assets/queries/terraform/gcp/kubernetes_web_ui_is_not_disabled/test/positive3.tf
Outdated
Show resolved
Hide resolved
assets/queries/terraform/gcp/kubernetes_web_ui_is_not_disabled/metadata.json
Outdated
Show resolved
Hide resolved
cx-miguel-dasilva
approved these changes
Jan 27, 2026
Collaborator
cx-miguel-dasilva
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great Work!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
feature
New feature
gcp
PR related with GCP Cloud
kubernetes
Kubernetes query
query
New query feature
terraform
Terraform query
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.








Reason for Proposed Changes
Proposed Changes
addons_config.kubernetes_dashboard.disabledis defined to false.kubernetes_dashboardis not defined, the default behaviour is to disable de dashboard, which should not be flagged.google_container_clusterresource, which was released approximately 6 years ago.google_container_clusterdoes not have the blockaddons_configdefined or when the addonkubernetes_dashboardis not defined inside theaddons_configblock. Both these cases are only flagged when the GKE version is under 1.10 using the value present on themin_master_versionfield. For versions above or equal to 1.10, it will not return any result since in these versions, the kubernetes_dashboard is disabled by default.addons_config.kubernetes_dashboard.disabledis set tofalse.I submit this contribution under the Apache-2.0 license.