fix: rename 'Save Changes' to 'Close' in settings modal#793
Open
Arsh-sudo wants to merge 1 commit into
Open
Conversation
Settings changes apply instantly on toggle so the 'Save Changes' button was misleading. Renamed to 'Close' and simplified the click handler to just close the modal since no explicit save action is needed. Closes Charushi06#572
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #572
Fixes misleading "Save Changes" button in the Settings modal.
Problem
Settings changes (Dark Mode, Compact View, etc.) apply instantly
on toggle via
changeevent listeners. The "Save Changes" button atthe bottom was misleading — it suggested changes were pending, but
they were already applied.
Fix
localStorage.setItemcalls from the button(settings already save on toggle)
Behavior
Before: Button said "Save Changes" but changes were already applied
After: Button says "Close" — accurately reflects its actual function
Files Changed
index.html— button text + click handler