feat: add comprehensive form validation for login and signup forms#786
Open
Parthiva302 wants to merge 1 commit into
Open
feat: add comprehensive form validation for login and signup forms#786Parthiva302 wants to merge 1 commit into
Parthiva302 wants to merge 1 commit into
Conversation
- Add email format validation - Add password strength checker with real-time feedback - Add confirmation password matching - Add loading state and error handling - Add success/error messages - Disable submit button until form is valid - Improve UX with clear error messages - Fixes form validation issue
Author
|
Hi @Charushi06 I've implemented comprehensive form validation for the login and signup forms! What I Did:Email Validation
Password Strength Checker
Confirmation Password Matching (signup)
Form Submission
User Experience
Testing Done:All validation rules tested Impact:
Ready for review! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implements comprehensive form validation for login and signup forms
to improve security and user experience.
Changes Made
Validation Features
✅ Email validation (must contain @ and valid domain)
✅ Password strength meter
✅ Real-time requirement feedback
✅ Confirmation password matching
✅ Loading state during submission
✅ Error handling and display
✅ Success messages
Testing Done
✅ Tested invalid email submission (correctly rejected)
✅ Tested weak password (correctly rejected)
✅ Tested missing capital letter (correctly rejected)
✅ Tested missing special character (correctly rejected)
✅ Tested mismatched passwords (correctly rejected)
✅ Tested valid email (correctly accepted)
✅ Tested strong password (correctly accepted)
✅ Tested matching passwords (correctly accepted)
✅ Tested error messages (appear correctly)
✅ Tested success messages (appear correctly)
✅ Tested submit button disabled state (works correctly)
✅ Tested on mobile view (responsive)
✅ Tested on desktop view (works correctly)
Files Changed
Related Issues
Fixes: [#743]