Switch from twisted logging back to python logging module #97
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
I don't see any info logs with this change :/ Before: After: |
Contributor
Author
|
Interesting. loglevel=INFO in your "after" logs? This is when I set loglevel=WARN This is when I set loglevel=INFO |
Contributor
|
Got it! WARN is default. |
jacomago
requested changes
Nov 15, 2024
server/recceiver/cfstore.py
Outdated
| continue | ||
| pvInfoByName[info["pvName"]] = info | ||
| _log.debug("Add record: {rid}: {info}", rid=rid, info=info) | ||
| _log.debug("Add record: {rid}: {info}".warning(rid=rid, info=info)) |
Contributor
There was a problem hiding this comment.
should be .format not .warning
Contributor
Author
There was a problem hiding this comment.
Ah yes, great catch! Fixed
properly escape curly brace in log message Fix typo for string format call
|
jacomago
approved these changes
Nov 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This addresses #96
I've tried to get twisted logging to use the conf file loglevel but it hasn't been successful. These attempts mostly revolved around adding this logic to application.py
It works fine for some log messages but certain log messages like
_log.debug('announce to {s}'.format(s=A))show up in the logs no matter what. So I suggest we revert back to the python logging module unless someone else can figure out the twisted logging since IMO this issue is a blocker to creating a new release.