Skip to content

refactor: enforce clean layer separation across repository, service, and controller #216

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
anderslindho wants to merge 4 commits into
base: master
Choose a base branch
from

refactor(web/v0): introduce DTO layer at the controller boundary

1863ef6
Select commit
Loading
Failed to load commit list.
Draft

refactor: enforce clean layer separation across repository, service, and controller #216

refactor(web/v0): introduce DTO layer at the controller boundary
1863ef6
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded May 7, 2026 in 29s

Quality Gate passed

Issues
18 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check warning on line 280 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdChannelWithItems" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1rau&open=AZ4Ct85j2SYqQQEu1rau&pullRequest=216

Check warning on line 282 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "renamedChannel" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1rav&open=AZ4Ct85j2SYqQQEu1rav&pullRequest=216

Check warning on line 334 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "updatedChannel" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1ray&open=AZ4Ct85j2SYqQQEu1ray&pullRequest=216

Check warning on line 731 in src/test/java/org/phoebus/channelfinder/TagControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdTags" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct86p2SYqQQEu1ra3&open=AZ4Ct86p2SYqQQEu1ra3&pullRequest=216

Check warning on line 717 in src/test/java/org/phoebus/channelfinder/PropertyControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "updatedProperty" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct81f2SYqQQEu1rap&open=AZ4Ct81f2SYqQQEu1rap&pullRequest=216

Check warning on line 160 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdChannel" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1ras&open=AZ4Ct85j2SYqQQEu1ras&pullRequest=216

Check warning on line 293 in src/test/java/org/phoebus/channelfinder/TagControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdTags" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct86p2SYqQQEu1raz&open=AZ4Ct86p2SYqQQEu1raz&pullRequest=216

Check warning on line 462 in src/test/java/org/phoebus/channelfinder/TagControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdTagWithChannels" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct86p2SYqQQEu1ra1&open=AZ4Ct86p2SYqQQEu1ra1&pullRequest=216

Check warning on line 279 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdChannel" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1rat&open=AZ4Ct85j2SYqQQEu1rat&pullRequest=216

Check warning on line 522 in src/test/java/org/phoebus/channelfinder/TagControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "returnedTag" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct86p2SYqQQEu1ra2&open=AZ4Ct86p2SYqQQEu1ra2&pullRequest=216

Check warning on line 1339 in src/test/java/org/phoebus/channelfinder/PropertyControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdProperties" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct81f2SYqQQEu1raq&open=AZ4Ct81f2SYqQQEu1raq&pullRequest=216

Check warning on line 283 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "renamedChannelWithItems" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1raw&open=AZ4Ct85j2SYqQQEu1raw&pullRequest=216

Check warning on line 461 in src/test/java/org/phoebus/channelfinder/TagControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdTag" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct86p2SYqQQEu1ra0&open=AZ4Ct86p2SYqQQEu1ra0&pullRequest=216

Check warning on line 322 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdChannel" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1rax&open=AZ4Ct85j2SYqQQEu1rax&pullRequest=216

Check warning on line 355 in src/test/java/org/phoebus/channelfinder/PropertyControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdProperties" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct81f2SYqQQEu1ran&open=AZ4Ct81f2SYqQQEu1ran&pullRequest=216

Check warning on line 713 in src/test/java/org/phoebus/channelfinder/PropertyControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdProperty" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct81f2SYqQQEu1rao&open=AZ4Ct81f2SYqQQEu1rao&pullRequest=216

Check warning on line 756 in src/test/java/org/phoebus/channelfinder/TagControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdTag" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct86p2SYqQQEu1ra4&open=AZ4Ct86p2SYqQQEu1ra4&pullRequest=216

Check warning on line 116 in src/test/java/org/phoebus/channelfinder/ChannelControllerIT.java

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this unused "createdChannel" local variable. 

See more on https://sonarcloud.io/project/issues?id=ChannelFinder_ChannelFinderService&issues=AZ4Ct85j2SYqQQEu1rar&open=AZ4Ct85j2SYqQQEu1rar&pullRequest=216
View more details on SonarQubeCloud