Skip to content

Fix incorrect drip quota consumption#448

Draft
sudo-shashank wants to merge 2 commits intomainfrom
shashank/fix-rate-limiter
Draft

Fix incorrect drip quota consumption#448
sudo-shashank wants to merge 2 commits intomainfrom
shashank/fix-rate-limiter

Conversation

@sudo-shashank
Copy link
Copy Markdown
Contributor

@sudo-shashank sudo-shashank commented May 7, 2026

Summary of changes

Changes introduced in this pull request:

Reference issue to close (if applicable)

Closes #449

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation. All new code
    adheres to the team's
    documentation standards,
  • I have added tests that prove my fix is effective or that my feature works
    (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes
    should be reflected in this document.

@coderabbitai
Copy link
Copy Markdown
Contributor

coderabbitai Bot commented May 7, 2026

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 1530ccc9-9475-4ed7-b625-56ca4edf8797

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch shashank/fix-rate-limiter

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented May 7, 2026

Codecov Report

❌ Patch coverage is 54.34783% with 63 lines in your changes missing coverage. Please review.
✅ Project coverage is 40.15%. Comparing base (df2e6cc) to head (e46bd04).

Files with missing lines Patch % Lines
src/faucet/server.rs 0.00% 40 Missing ⚠️
src/faucet/server_api.rs 0.00% 17 Missing ⚠️
src/faucet/rate_limiter.rs 95.89% 3 Missing ⚠️
src/utils/drip_amount.rs 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #448      +/-   ##
==========================================
+ Coverage   39.32%   40.15%   +0.82%     
==========================================
  Files          42       42              
  Lines        2919     3046     +127     
==========================================
+ Hits         1148     1223      +75     
- Misses       1771     1823      +52     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Rate Limiter: Incorrect drip quota consumption before the on-chain submission

2 participants