feat: [Indexer] implemented event fetching and processing#162
feat: [Indexer] implemented event fetching and processing#162
Conversation
Summary of ChangesHello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a comprehensive event fetching and processing pipeline for the indexer. It establishes a reliable streaming client for the Canton ledger, capable of handling disconnections and authentication issues. A generic framework for decoding and batching events is provided, along with a specific implementation for Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request introduces a well-structured and robust implementation for fetching and processing events from the Canton ledger. The new streaming package provides a solid foundation with a generic, reconnecting client, and the indexer/engine builds upon it effectively. The code demonstrates good practices like dependency inversion, clear separation of concerns, and thorough testing. My review includes a few suggestions to refactor small pieces of code to enhance clarity and reduce redundancy.
| if !ev.IsNone("fromParty") { | ||
| v := ev.OptionalPartyField("fromParty") | ||
| if v != "" { | ||
| fromPartyID = &v | ||
| } | ||
| } |
Closes #158