-
Notifications
You must be signed in to change notification settings - Fork 1
feat: add non-custodial signing flow (key_mode, prepare/execute API, external registration) #152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
01effe6
Add key_mode DB column, user model, and SDK prepare/execute transfer
salindne 33e124a
fix: use IssuerParty instead of RelayerParty after config-v2 rename
salindne e9b0910
Make SDK token client stateless, add request validation
salindne dd69d73
Add non-custodial transfer HTTP API (prepare/execute endpoints)
salindne 75e867d
Move transfer cache to service layer, use token config for symbols
salindne 6e7251c
Add two-step external user registration with topology signing
salindne 2e469df
Move whitelist check before external registration branch
salindne 23d9cb0
fix: align test mock expectations with whitelist-first check order
salindne c14f8b0
Add integration test and Snap testing documentation
salindne 87d2607
Fix test expectations for whitelist check reorder, remove dead assign…
salindne 73b9209
Merge pull request #155 from ChainSafe/feature/111-e-integration-test
salindne 44b9fbb
Merge pull request #154 from ChainSafe/feature/111-d-registration
salindne e7092e3
Merge pull request #153 from ChainSafe/feature/111-c-http-api
salindne 18329c0
fix: cache TTL ownership, add size limit, remove redundant migration
salindne 0c8f3a0
refactor: extract cache and service interfaces, add transfer log deco…
salindne 4e8b20c
test: add unit tests for PrepareExternalRegistration and TransferService
salindne 0977899
refactor: move request validation from service layer to HTTP handlers
salindne 76d4536
fix: use crypto.DecompressPubkey for secp256k1 key decompression
salindne dbd3e90
refactor: move PreparedTransferCache from cantonsdk to transfer package
salindne 20ee795
refactor: remove Start() from TransferCache interface
salindne 1fd0a61
fix: gofmt alignment in server constants
salindne b846be4
refactor: replace hand-written mocks with mockery-generated mocks
salindne c814cee
docs: fix fingerprint format and error message in snap testing guide
salindne File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
topologyCache.Start(ctx)is launched as a goroutine without explicit panic recovery. While theStartmethod itself handles context cancellation, a panic originating from within thecleanupmethod or any other part of this goroutine could lead to an unhandled crash of the application. Consider adding adeferwithrecover()to log and handle such panics gracefully.