Conversation
| return pd.DataFrame({"cap": cap, "cop": cop}) | ||
| else: | ||
| logger.error(f"Equipment '{e.eq_id}' heating COP and capacity curves are of different lengths.") | ||
| raise ValueError(f"Equipment '{e.eq_id}' heating COP and capacity curves are of different lengths.") |
There was a problem hiding this comment.
not sure whether the ValueError is needed if a logger error is present; i've added both but can delete if needed
| }, | ||
| "constraints": { | ||
| "min_temp_C": 38, | ||
| "max_temp_C": 52 |
There was a problem hiding this comment.
general comment for HPs: these constraints outside the supply temp data refer to the min/max supply temps for that model. this may be useful for the user input field (would probably be a couple more steps to extract the listed temps, convert to floats, and read the min/max) - but is not necessary, so can be deleted once the updates are complete
| id="edit-awhp-h-supply-t-select", | ||
| label="Heating supply temperature", | ||
| placeholder="None", | ||
| data=["35", "38", "38.9", "43.3", "45", "48.9", "50", "52", "54.4", "60"], # update to be filled by callback based on currently selected HP |
There was a problem hiding this comment.
for both AWHP and WWHP - this list is just all of the supply temps in the database, so during the calcs the tool will throw an error if a value that isn't listed for the current HP model is selected. the eventual goal for this input is that it's a number input, limited on both ends by the min/max temps from the database for whatever HP model is currently selected.
we will also want to be able to set this input to something that indicates HHW reset, not sure what the best way to approach that is
| Output("edit-awhp-select", "data"), | ||
| Output("edit-awhp-select", "value"), | ||
| # Output("edit-awhp-h-supply-t-select", "data"), # added for autofill callback, not implemented | ||
| Output("edit-awhp-h-supply-t-select", "value"), |

for #54:
next steps to complete this issue: