Skip to content
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,11 @@

We follow the CalVer (https://calver.org/) versioning scheme: YY.MINOR.MICRO.

26.10.0 (2026-05-07)
====================

* OSF4I In-progress SSO Project - FE Piece

26.9.2 (2026-05-06)
===================

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "osf",
"version": "26.9.2",
"version": "26.10.0",
"scripts": {
"ng": "ng",
"analyze-bundle": "ng build --configuration=analyze-bundle && source-map-explorer dist/**/*.js --no-border-checks",
Expand Down
12 changes: 9 additions & 3 deletions src/app/core/services/auth.service.ts
Original file line number Diff line number Diff line change
Expand Up @@ -41,8 +41,14 @@ export class AuthService {
}

this.loaderService.show();
const loginUrl = `${this.casUrl}/login?${urlParam({ service: `${this.webUrl}/login`, next: window.location.href })}`;
window.location.href = loginUrl;

const serviceUrl = new URL(`${this.webUrl}/login`);
serviceUrl.searchParams.set('next', window.location.href);

const loginUrl = new URL(`${this.casUrl}/login`);
loginUrl.searchParams.set('service', serviceUrl.toString());

window.location.href = loginUrl.toString();
}

navigateToOrcidSignIn(): void {
Expand Down Expand Up @@ -79,7 +85,7 @@ export class AuthService {

if (isPlatformBrowser(this.platformId)) {
this.cookieService.deleteAll();
window.location.href = `${this.webUrl}/logout/?next=${encodeURIComponent(nextUrl || '/')}`;
window.location.href = `${this.webUrl}/logout/?next=${encodeURIComponent(nextUrl || `${window.location.origin}/`)}`;
}
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ describe('ProfileInformationComponent', () => {
},
institutionalRequestAccessEnabled: true,
logoPath: 'logo.png',
sso_availability: 'Public',
},
];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,7 @@ describe('AddComponentDialogComponent', () => {
assets: { logo: '', logo_rounded: '', banner: '' },
institutionalRequestAccessEnabled: false,
logoPath: '',
sso_availability: 'Public',
},
{
id: 'inst-2',
Expand All @@ -76,6 +77,7 @@ describe('AddComponentDialogComponent', () => {
assets: { logo: '', logo_rounded: '', banner: '' },
institutionalRequestAccessEnabled: false,
logoPath: '',
sso_availability: 'Public',
},
];

Expand All @@ -91,6 +93,7 @@ describe('AddComponentDialogComponent', () => {
assets: { logo: '', logo_rounded: '', banner: '' },
institutionalRequestAccessEnabled: false,
logoPath: '',
sso_availability: 'Public',
},
];

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -68,6 +68,7 @@ describe('AffiliatedInstitutionSelectComponent', () => {
},
institutionalRequestAccessEnabled: false,
logoPath: '/logos/unavailable.png',
sso_availability: 'Unavailable',
};

fixture.componentRef.setInput('institutions', mockInstitutions);
Expand Down Expand Up @@ -134,6 +135,7 @@ describe('AffiliatedInstitutionSelectComponent', () => {
},
institutionalRequestAccessEnabled: false,
logoPath: '/logos/unavailable.png',
sso_availability: 'Unavailable',
};

fixture.componentRef.setInput('institutions', mockInstitutions);
Expand Down Expand Up @@ -181,6 +183,7 @@ describe('AffiliatedInstitutionSelectComponent', () => {
},
institutionalRequestAccessEnabled: false,
logoPath: '/logos/unavailable.png',
sso_availability: 'Unavailable',
};

fixture.componentRef.setInput('institutions', mockInstitutions);
Expand Down
1 change: 1 addition & 0 deletions src/app/shared/mappers/institutions/institutions.mapper.ts
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ export class InstitutionsMapper {
logoPath: data.attributes.logo_path,
userMetricsUrl: data.relationships?.user_metrics?.links?.related?.href,
linkToExternalReportsArchive: data.attributes.link_to_external_reports_archive,
sso_availability: data.attributes.sso_availability,
};
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ interface InstitutionAttributesJsonApi {
institutional_request_access_enabled: boolean;
logo_path: string;
link_to_external_reports_archive: string;
sso_availability: string;
}

interface InstitutionLinksJsonApi {
Expand Down
1 change: 1 addition & 0 deletions src/app/shared/models/institutions/institutions.model.ts
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ export interface Institution {
logoPath: string;
userMetricsUrl?: string;
linkToExternalReportsArchive?: string;
sso_availability: string;
}

export interface InstitutionAssets {
Expand Down
1 change: 1 addition & 0 deletions src/testing/mocks/institution.mock.ts
Original file line number Diff line number Diff line change
Expand Up @@ -13,4 +13,5 @@ export const MOCK_INSTITUTION = {
},
institutionalRequestAccessEnabled: true,
logoPath: 'https://mockinstitution.org/logo.png',
sso_availability: 'Public',
};
Loading