Skip to content

Set slug property only if defined in create and release #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cubap merged 1 commit into from
Dec 9, 2025
Merged

Set slug property only if defined in create and release #235

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions controllers/crud.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ import { _contextid, idNegotiation, generateSlugId, ObjectID, createExpressError
* */
const create = async function (req, res, next) {
res.set("Content-Type", "application/json; charset=utf-8")
let slug = null
let slug
if(req.get("Slug")){
let slug_json = await generateSlugId(req.get("Slug"), next)
if(slug_json.code){
Expand All @@ -31,7 +31,9 @@ const create = async function (req, res, next) {
let context = req.body["@context"] ? { "@context": req.body["@context"] } : {}
let provided = JSON.parse(JSON.stringify(req.body))
let rerumProp = { "__rerum": utils.configureRerumOptions(generatorAgent, provided, false, false)["__rerum"] }
rerumProp.__rerum.slug = slug
if(slug){
rerumProp.__rerum.slug = slug
}
const providedID = provided._id
const id = isValidID(providedID) ? providedID : ObjectID()
delete provided["__rerum"]
Expand Down
6 changes: 4 additions & 2 deletions controllers/release.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import { _contextid, ObjectID, createExpressError, getAgentClaim, parseDocumentI
const release = async function (req, res, next) {
let agentRequestingRelease = getAgentClaim(req, next)
let id = req.params["_id"]
let slug = null
let slug
let err = {"message":""}
let treeHealed = false
if(req.get("Slug")){
Expand Down Expand Up @@ -75,7 +75,9 @@ const release = async function (req, res, next) {
if (null !== originalObject){
safe_original["__rerum"].isReleased = new Date(Date.now()).toISOString().replace("Z", "")
safe_original["__rerum"].releases.replaces = previousReleasedID
safe_original["__rerum"].slug = slug
if(slug){
safe_original["__rerum"].slug = slug
}
if (previousReleasedID !== "") {
// A releases tree exists and an ancestral object is being released.
treeHealed = await healReleasesTree(safe_original)
Expand Down