-
Notifications
You must be signed in to change notification settings - Fork 3
TinyNode NPM Package Updates #104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR updates NPM package dependencies for the TinyNode project and refactors route existence testing. The primary purpose is to modernize dependencies and improve test organization by moving route detection logic into a reusable function.
- Updated multiple NPM packages to newer versions including Express, Jest, and other core dependencies
- Refactored route existence testing by extracting duplicated logic into a reusable
routeExistsfunction - Moved demo interface tests to a separate test file and added file existence checks
Reviewed Changes
Copilot reviewed 3 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| package.json | Updated NPM dependencies to newer versions and Node.js engine requirement |
| routes/tests/mount.test.js | Refactored route existence tests with reusable function and added file existence checks |
| routes/tests/index.test.js | New test file containing demo interface tests moved from mount.test.js |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
| * @returns {boolean} - True if all routes are found | ||
| */ | ||
| function routeExists(routes) { | ||
| const stack = app.router.stack |
Copilot
AI
Oct 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The property should be app._router.stack instead of app.router.stack. Express apps use the private _router property to access the router stack.
| const stack = app.router.stack | |
| const stack = app._router.stack |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NOT ANYMORE BECAUSE EXPRESS 5
Includes updated exists tests.