Skip to content

Refactor Member Ignoring Method smell in Device class #968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
emaiannone wants to merge 1 commit into
base: development
Choose a base branch
from
Open

Refactor Member Ignoring Method smell in Device class #968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions AIMSICD/src/main/java/com/secupwn/aimsicd/utils/Device.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -159,15 +159,14 @@ public void refreshDeviceInfo(TelephonyManager tm, Context context) {
dataState = getDataState(tm);
}

private Optional<String> getSimInformation(Supplier<String> simInfoSupplier) {
try {
return Optional.ofNullable(simInfoSupplier.get());
} catch (Exception e) {
// SIM methods can cause Exceptions on some devices
log.error("Failed to get SIM-Information", e);
}
return Optional.empty();
}
private static Optional<String> getSimInformation(Supplier<String> simInfoSupplier) {
try {
return Optional.ofNullable(simInfoSupplier.get());
} catch (Exception e) {
log.error("Failed to get SIM-Information", e);
}
return Optional.empty();
}

/**
* SIM Country
Expand Down