Skip to content

IDE-289 Fix import actor from local project #5108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Frajhamster wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

IDE-289 Fix import actor from local project #5108

Frajhamster wants to merge 1 commit into from

Conversation

@Frajhamster
Copy link
Contributor

@Frajhamster Frajhamster commented Sep 9, 2025 •
edited
Loading

In this story the button "Import from local" has been added back and its functionality has been fixed.

Jira Ticket: https://catrobat.atlassian.net/browse/IDE-289

Your checklist for this pull request

Please review the contributing guidelines and wiki pages of this repository.

  • Include the name of the Jira ticket in the PR’s title
  • Include a summary of the changes plus the relevant context
  • Choose the proper base branch (develop)
  • Confirm that the changes follow the project’s coding guidelines
  • Verify that the changes generate no compiler or linter warnings
  • Perform a self-review of the changes
  • Verify to commit no other files than the intentionally changed ones
  • Include reasonable and readable tests verifying the added or changed behavior
  • Confirm that new and existing unit tests pass locally
  • Check that the commits’ message style matches the project’s guideline
  • Stick to the project’s gitflow workflow
  • Verify that your changes do not have any conflicts with the base branch
  • After the PR, verify that all CI checks have passed
  • Post a message in the catroid-stage or catroid-ide Slack channel and ask for a code reviewer

@Frajhamster Frajhamster force-pushed the IDE-289 branch 2 times, most recently from abdcacf to c1ac486 Compare October 1, 2025 18:25
@Frajhamster Frajhamster force-pushed the IDE-289 branch 2 times, most recently from 5aab4e9 to e03f0e9 Compare October 22, 2025 12:55
@Frajhamster Frajhamster force-pushed the IDE-289 branch 4 times, most recently from e1c9208 to 25010fc Compare November 20, 2025 20:47
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 20, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@dorianpercic dorianpercic self-requested a review December 19, 2025 10:00
dorianpercic
dorianpercic reviewed Dec 20, 2025
View reviewed changes
Copy link
Contributor

@dorianpercic dorianpercic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR looks good, but I am not sure if we need a UI test for this.
@reichli what is the test strategy of Catrobat right now? Last info I had was basically no UI tests anymore, since we have so many already.

@reichli
Copy link
Contributor

reichli commented Dec 22, 2025

what is the test strategy of Catrobat right now? Last info I had was basically no UI tests anymore, since we have so many already.

Yes, clear preference given towards integration- and unit-tests.

@dorianpercic dorianpercic self-requested a review December 25, 2025 13:10
dorianpercic
dorianpercic requested changes Dec 25, 2025
View reviewed changes
Copy link
Contributor

@dorianpercic dorianpercic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Your test is not needed since there exists already the importObjectAndMergeGlobals UIEspresso test, which fails on develop. With this PR the test succeeds again and has enough coverage for the feature in my opinion.

@reichli reichli added the Active Member Tickets that are assigned to members that are still currently active label Dec 25, 2025
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@Frajhamster
Copy link
Contributor Author

Frajhamster commented Dec 26, 2025

Removed the test

@dorianpercic dorianpercic self-requested a review December 28, 2025 11:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dorianpercic dorianpercic dorianpercic approved these changes

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

Active Member Tickets that are assigned to members that are still currently active

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@Frajhamster @reichli @dorianpercic