Feature/open card archive toggle #2768
Conversation
TheLastProject
left a comment
TheLastProject
left a comment
There was a problem hiding this comment.
Looks generally correct. Have a few small nitpicks and questions
| if (Build.VERSION.SDK_INT >= Build.VERSION_CODES.O) { | ||
| menu.findItem(R.id.action_archive_unarchive).setTooltipText(getString(R.string.unarchive)); | ||
| } |
There was a problem hiding this comment.
What difference does this setTooltip call make? I'm not seeing any difference between this and the favourite button when I press or long-press it.
There was a problem hiding this comment.
It adds a small tooltip that appears when you long-press or hover over the icon (on Android 8.0+). It’s mainly for accessibility and clarity — helps users understand what the icon does. The difference is subtle, so it’s easy to miss unless you long-press for a moment.
There was a problem hiding this comment.
Well, that's the point I'm trying to make: the long-press behaviour is exactly the same for this and the favourite button but the favourite button doesn't have this function call (on Android 15 at least):
For hover, I'm not sure how to test that, any info?
app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java
Outdated
Show resolved
Hide resolved
app/src/main/java/protect/card_locker/LoyaltyCardViewActivity.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
This icon seems to use a completely different arrow than the other archive icons. Can we maybe make this icon consistent with the other 2?
(Seems this one is from "Material Symbols Outlined", while the others are from "Outlined" and "Filled", so using "archive" from the "Outlined" set should fix this)
| This icon (ic_outline_archive.xml) | loyalty_card_icon_archived.xml | ic_unarchive.xml |
|---|---|---|
 |
 |
 |
There was a problem hiding this comment.
(I think it might also be better to use "loyalty_card_icon_archived.xml" for when the icon is archived, as that is more consistent with the favourite icon which shows the current state as opposed to the action pressing the button will do, but I'm honestly not sure what the official Google design language says should be used)
There was a problem hiding this comment.
Originally, the Archive icon represented the action (like Gmail), but Gmail removes the item from the list after archiving. Since we’re keeping the card visible in the list, it makes more sense to show the icon as a current state indicator rather than an action.
Star icons are similar — they show state. So now, Unarchive shows if the card is unarchived, Archive if it’s archived, making the status clear at a glance.
There was a problem hiding this comment.
But now the star and archive buttons have completely opposite semantics, despite being next to each other. Star shows the current state, archive shows what state change will happen when you press it. That seems very confusing to me, which is why I suggested making both show the current state for consistency, using the non-outline vs. outline differences to show the difference in if it's archived or not (like how the star for favouriting currently works)
…java Co-authored-by: Sylvia van Os <sylvia@hackerchick.me>
Co-authored-by: Sylvia van Os <sylvia@hackerchick.me>
Changed archive icon
2 participants
Fixes: #2764
card_view_menu.xml— removed unnecessary nested menu items for the action popup (Android handles this automatically).card_view_menu.xmlhas changed