fix: restore readable text in PRCreateModal branch dropdowns on dark theme#243
fix: restore readable text in PRCreateModal branch dropdowns on dark theme#243R-Hart80 wants to merge 2 commits into
Conversation
The labeled main button now triggers collapse-one-level (conservative) and the icon-only add-on triggers collapse-all, matching the Expand group's convention. Fixes CatholicOS#208. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…theme Added explicit text-slate-900/dark:text-white to both <select> elements and bg-white/dark:bg-slate-700 + text colors to each <option> so the selected value and dropdown popup are readable in dark mode. Fixes CatholicOS#204. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
Warning Rate limit exceeded
You’ve run out of usage credits. Purchase more in the billing tab. ⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Problem
Closes #204.
In
PRCreateModal, the From and Into branch<select>elements hadbg-transparentwith no explicittext-*color. In dark mode, the inherited text color (near-white) rendered white-on-white against the browser's default white dropdown background. Both the selected value and the popup options were unreadable.Fix
Two small additions to both dropdowns (
components/pr/PRCreateModal.tsx):<select>— addedtext-slate-900 dark:text-whiteso the selected branch label is always readable regardless of theme.<option>— addedclassName="bg-white text-slate-900 dark:bg-slate-700 dark:text-white"so the native dropdown popup respects the active theme.Same change applied to both the From (line ~118) and Into (line ~140) dropdowns.
Testing
LanguagePicker.test.tsx, unrelated)🤖 Generated with Claude Code