Skip to content

fix: restore readable text in PRCreateModal branch dropdowns on dark theme#243

Open
R-Hart80 wants to merge 2 commits into
CatholicOS:devfrom
R-Hart80:fix/pr-create-modal-dark-theme-select
Open

fix: restore readable text in PRCreateModal branch dropdowns on dark theme#243
R-Hart80 wants to merge 2 commits into
CatholicOS:devfrom
R-Hart80:fix/pr-create-modal-dark-theme-select

Conversation

@R-Hart80
Copy link
Copy Markdown
Contributor

Problem

Closes #204.

In PRCreateModal, the From and Into branch <select> elements had bg-transparent with no explicit text-* color. In dark mode, the inherited text color (near-white) rendered white-on-white against the browser's default white dropdown background. Both the selected value and the popup options were unreadable.

Fix

Two small additions to both dropdowns (components/pr/PRCreateModal.tsx):

  1. <select> — added text-slate-900 dark:text-white so the selected branch label is always readable regardless of theme.
  2. <option> — added className="bg-white text-slate-900 dark:bg-slate-700 dark:text-white" so the native dropdown popup respects the active theme.

Same change applied to both the From (line ~118) and Into (line ~140) dropdowns.

Testing

  • Dark theme: selected branch label is readable in both dropdowns
  • Dark theme: dropdown popup options are readable
  • Light theme: no regression — dropdowns continue to render correctly
  • Existing test suite: 158/159 pass (1 pre-existing failure in LanguagePicker.test.tsx, unrelated)

🤖 Generated with Claude Code

R-Hart80 and others added 2 commits May 11, 2026 10:39
The labeled main button now triggers collapse-one-level (conservative)
and the icon-only add-on triggers collapse-all, matching the Expand
group's convention. Fixes CatholicOS#208.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…theme

Added explicit text-slate-900/dark:text-white to both <select> elements
and bg-white/dark:bg-slate-700 + text colors to each <option> so the
selected value and dropdown popup are readable in dark mode. Fixes CatholicOS#204.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
@coderabbitai
Copy link
Copy Markdown

coderabbitai Bot commented May 11, 2026

Warning

Rate limit exceeded

@R-Hart80 has exceeded the limit for the number of commits that can be reviewed per hour. Please wait 54 minutes and 9 seconds before requesting another review.

You’ve run out of usage credits. Purchase more in the billing tab.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 9b5ea668-9189-42d7-8af6-71b42e67594b

📥 Commits

Reviewing files that changed from the base of the PR and between 0233a83 and 5896f0b.

📒 Files selected for processing (2)
  • components/editor/shared/EntityTreeToolbar.tsx
  • components/pr/PRCreateModal.tsx
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 11, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PRCreateModal: From/Into branch dropdowns render white-on-white in dark theme

1 participant