Fix hardcoded admin creatorId and CI health check parse errors #67
+212
−13
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…check module, update CI workflow - Enhanced admin auth to extract user ID from request headers - Updated frame-templates route to use authenticated admin user ID - Created scripts/health/check-health.js module for safe health report parsing - Updated dependency-health.yml workflow to use new health check module - Removed jq dependency and inline bash parsing that caused CI failures - Added comprehensive documentation for health check module Co-authored-by: SMSDAO <144380926+SMSDAO@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add DAO integration and service modules to CastQuest
Fix hardcoded admin creatorId and CI health check parse errors
Jan 15, 2026
SMSDAO
approved these changes
Jan 15, 2026
Member
SMSDAO
left a comment
SMSDAO
left a comment
There was a problem hiding this comment.
Fix hardcoded admin creatorId and CI health check parse errors#67
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes hardcoded admin authentication identifiers and replaces problematic bash/jq JSON parsing in CI workflows with a robust Node.js module. The changes ensure admin operations use authenticated context instead of fallback values and eliminate CI parse errors.
Changes:
- Enhanced admin authentication to extract and use admin user ID from request headers
- Replaced inline bash/jq health check parsing with dedicated Node.js module
- Updated frame template creation to prioritize authenticated admin context over hardcoded values
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/health/check-health.js | New Node.js module for safe JSON parsing and health status validation with comprehensive error handling |
| scripts/health/README.md | Documentation for the health check module including usage examples and integration guide |
| apps/admin/lib/auth.ts | Enhanced requireAdmin() to extract and return admin user ID from request headers |
| apps/admin/app/api/frame-templates/create/route.ts | Updated creator ID fallback chain to prioritize authenticated admin context |
| .github/workflows/dependency-health.yml | Replaced bash/jq parsing with Node.js health check module |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses all PR #63 review comments: eliminates hardcoded
system-admincreatorId, removes jq dependency causing CI parse failures, and resolves spacing/duplicate dependency issues.Changes
Admin Authentication Enhancement
x-admin-user-idrequest header inrequireAdmin()CI Health Check Module
scripts/health/check-health.jsreplaces inline bash + jq parsingAlready Resolved (commit 9ac723d)
drizzle-ormdependency removedVerification
All review comments addressed. No merge conflicts. TypeScript structure validated. Health check module tested against healthy/unhealthy/malformed/empty/missing scenarios.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.