-
Notifications
You must be signed in to change notification settings - Fork 2
Add thirty models #13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
joeyshuttleworth
wants to merge
89
commits into
master
Choose a base branch
from
fix_transition_matrix
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
89 commits
Select commit
Hold shift + click to select a range
be57ad5
Change default parameter handling
9d952fc
Remove unnecessary line from test
2297bf9
Add first 4 models. Add tests to generate .mmt and graph files
ae770ab
Add tests for connectedness as reversibility. Add models 4,5
0b6f9d8
Fix draw_graph handling of transition rates
d502827
Add more models
beacf8f
Fix get_transition_matrix. Fix reversibility check. Add show_html swi…
8904c6b
Merge branch 'master' into fix_transition_matrix
051a36f
Add models 11 and 30. Remove duplicated test file
a4b97e2
Merge branch 'fix_transition_matrix' of github.com:CardiacModelling/M…
5310b55
Lint and isort
57415dc
Update test_parameterise_rates
f199b6f
Add test_30_models.py
79f7295
Add myokit files for testing
7e21caf
Update pytest.yml
0afb97b
Update pytest.yml
bc4c4c9
Make single quote use more consistent
2d6c990
Fix indentation. Distribute trajectories according to number of traje…
17027f4
Fix sympy depreciation warning (latex output)
fe4f333
Add test for dataclass exception (must be subclass of state_attribute…
23835be
Merge branch 'fix_transition_matrix' of github.com:CardiacModelling/M…
b6ef7da
Raise TypeError not Exception
215898f
Remove old, broken test output
de33024
Fix test_bad_dataclass_exception
4d86220
Remove unnecessary checks on attribute dataclass
fef0edf
Lint
f1e03cb
Add models
f58dcc7
Add some models with HH-style gating
c2ccada
Sort imports
93b454f
Fix myokit model generation
663313a
Modify model3 to be disconnected model
351f199
Update tests for disceonnected model_03. Add auxiliary_variables dict…
fed5036
Change model parameterisation
846a079
Standardise model parameterisation
205efd3
Fix model generation
6ed6f62
Simplify Kemp model into two connected components
a1a2777
Replace depcreciated np.NaN with np.nan
a9916e4
NaN -> nan
f440e56
Add model 20
aa7b755
Add model20.py
ab8aed9
Parameterise Mazhari model. Fix parameter bug
b5e072c
Change order of state addition
c4843a3
Reorder parameters
2f43fa2
Strenghten test for "get_eliminate_state..." Move permutation code to…
909b14b
Remove print
bd92d1c
Fix doctstring
a3dbc80
Update build system
a1206b3
Fix whitespace
cb10d50
Update docstrings, .gitignore, and type hints
b37b182
Update init and use clearer param names. Update models
1fc213e
Update models and tests
d277853
Simplify exception for undefined parameters
2c29004
Change error type to align with code
c62b4bd
More docstring change. Variable name change
7ee29d3
Lint
09c802a
Add drug_bound field by default
84f6bf2
Update param names. Remove debug format string
b997979
Turn off E501 "line too long"
f3da65d
Lint
b39677f
Remove () from class defn
3f166b5
Fix unused var
4654c81
Modify project setup for isort
94ecad8
Merge branch 'master' into HEAD
035f681
Update workflow
f42b1df
Update isort conf
32c6d39
Update isort settings (again)
95dedd7
Change isort settings
afd9926
Update isort settings
fb54457
Remove unnecessary "get" function
d6f257c
Fix docstrings using ruff. Add ruff and sphinx to docs optional depen…
66f65b8
Delete setup.py
2ea48f7
Add extra models
9bfa6e8
Improve exception messages
fc56ad3
Lint
563a76e
Lint and isort
43bf6ef
Revert ah<->bh swap
joeyshuttleworth 2e8f31f
Fix mangled model file
b43c386
Remove `open_state` logic form 30 models
3e734d0
Fix tests and use pytest
756ced2
Split readme sentences onto newlines
fdbfa36
Lint, isort
a61969c
Remove old config
fe63345
move config to toml
3f3a02d
Tidy 30 new models
dc04819
Restore flake8 file
73ae5fc
isort
e7ac78c
Fix model 0 parameter
0631f15
Eliminate correct state in test comparison
4874485
Remove redundant 'open_state' vars
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,14 +1,4 @@ | ||
| [flake8] | ||
| max_line_length = 120 | ||
| ignore = | ||
| # allow empty line at end of file | ||
| W391, | ||
| # break before binary operator - allow either style | ||
| W503, | ||
| # break after binary operator - allow either style | ||
| W504, | ||
| # missing whitespace around arithmetic operator | ||
| E226, | ||
| exclude= | ||
| .git, | ||
| venv, | ||
| max-line-length = 120 | ||
| ignore = W391,W503,W504,E226,E501 | ||
| exclude = .git,.*, .venv,docs,build,doctrees,test_output,**/__pycache__,*.egg-info |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.